Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

Host header default and proxies #45

Closed
ctrimble opened this issue Jun 11, 2015 · 4 comments
Closed

Host header default and proxies #45

ctrimble opened this issue Jun 11, 2015 · 4 comments

Comments

@ctrimble
Copy link
Contributor

Defaulting the Host header to the local interfaces host name may not be the best default. When connecting to Etcd behind a proxy, the host header needs to match the host being contacted, otherwise the proxy will fail.

A better default would be to extract the host from the url being connected to. This would allow proxies to work as expected.

@jurmous
Copy link
Owner

jurmous commented Jun 15, 2015

Thanks for reporting this issue! It is indeed more sensible to use the host name of the URI being connected to.

@ctrimble
Copy link
Contributor Author

@jurmous, thanks for changing this. You may want to update the README.md as well, since it specifies the default behavior.

@jurmous
Copy link
Owner

jurmous commented Jun 16, 2015

Thanks for pointing me out! I will update it when this fix will be released in the next version. This way it will not confuse people visiting the github page and working with the current version.

@jurmous
Copy link
Owner

jurmous commented Jun 16, 2015

Released in 2.7.0 and I updated the README. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants