Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Mollie] Use connector_request_reference_id as reference to merchant #2539

Closed
wants to merge 1 commit into from

Conversation

SanchitMahajan236
Copy link

@SanchitMahajan236 SanchitMahajan236 commented Oct 10, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added connector_request_reference_id as reference to merchant according to issue #2304

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SanchitMahajan236 SanchitMahajan236 requested a review from a team as a code owner October 10, 2023 18:55
@SanchitMahajan236
Copy link
Author

I am new to rust and tried my best to contribute. So, I would love to get your feedback on if anything needs to be changed.

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 11, 2023
@prasunna09
Copy link
Contributor

Hi @SanchitMahajan236 ,
Please use following cargo commands -
cargo clippy --all-features
ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass and
cargo +nightly fmt to fix the failing formatting check

@SanchitMahajan236
Copy link
Author

I get this when I run the command: cargo clippy --all-features

Error:-

error: failed to run custom build command for `openssl-sys v0.9.90`

Caused by:
  process didn't exit successfully: `D:\GitHub\hyperswitch\target\debug\build\openssl-sys-0f397f02f302ffcf\build-script-main` (exit code: 101)
  --- stdout
  cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR
  X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
  OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_INCLUDE_DIR
  X86_64_PC_WINDOWS_MSVC_OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
  OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_DIR
  X86_64_PC_WINDOWS_MSVC_OPENSSL_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_DIR
  OPENSSL_DIR unset
  note: vcpkg did not find openssl: Could not find Vcpkg tree: No vcpkg installation found. Set the VCPKG_ROOT environment variable or run 'vcpkg integrate install' 

  --- stderr
  thread 'main' panicked at C:\Users\pranm\.cargo\registry\src\index.crates.io-6f17d22bba15001f\openssl-sys-0.9.90\build\find_normal.rs:190:5:


  Could not find directory of OpenSSL installation, and this `-sys` crate cannot
  proceed without this knowledge. If OpenSSL is installed and this crate had
  trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
  compilation process.

  Make sure you also have the development packages of openssl installed.
  For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

  If you're in a situation where you think the directory *should* be found
  automatically, please open a bug at https://github.com/sfackler/rust-openssl
  and include information about your system as well as this message.

  $HOST = x86_64-pc-windows-msvc
  $TARGET = x86_64-pc-windows-msvc
  openssl-sys = 0.9.90


  It looks like you're compiling for MSVC but we couldn't detect an OpenSSL
  installation. If there isn't one installed then you can try the rust-openssl
  README for more information about how to download precompiled binaries of
  OpenSSL:

  https://github.com/sfackler/rust-openssl#windows


  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

Can someone help me with this @prasunna09 ??

@SanchithHegde
Copy link
Member

Hey @SanchitMahajan236, did you install the openssl package using vcpkg?

Also, if you're comfortable, can we take this discussion about local system setup issues to Discord? I don't want to clutter the PR conversation thread with setup issues.

@SanchitMahajan236
Copy link
Author

SanchitMahajan236 commented Oct 12, 2023

@SanchithHegde Sure, please share your discord

@SanchithHegde
Copy link
Member

@SanchitMahajan236 You can join our Discord server and then ask your queries on the #dev-help-oss-contrib channel.

@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Mollie] Use connector_request_reference_id as reference to the connector
3 participants