Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Bitpay] Add order id as the reference id #2591

Merged
merged 6 commits into from
Nov 6, 2023
Merged

feat(connector): [Bitpay] Add order id as the reference id #2591

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5b5485
changes made
ashh1215 Oct 15, 2023
62c637b
Made Changes
ashh1215 Nov 2, 2023
56e9345
Changes Made
ashh1215 Nov 2, 2023
42db351
Changes made
ashh1215 Nov 3, 2023
085ef00
Merge branch 'main' into main
AkshayaFoiger Nov 5, 2023
4da4a53
Merge branch 'main' into main
AkshayaFoiger Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/router/src/connector/bitpay/transformers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ impl<F, T>
.data
.url
.map(|x| services::RedirectForm::from((x, services::Method::Get)));
let connector_id = types::ResponseId::ConnectorTransactionId(item.response.data.id);
let connector_id = types::ResponseId::ConnectorTransactionId(item.response.data.id.clone());
deepanshu-iiitu marked this conversation as resolved.
Show resolved Hide resolved
let attempt_status = item.response.data.status;
Ok(Self {
status: enums::AttemptStatus::from(attempt_status),
Expand All @@ -138,7 +138,7 @@ impl<F, T>
mandate_reference: None,
connector_metadata: None,
network_txn_id: None,
connector_response_reference_id: None,
connector_response_reference_id: Some(item.response.data.id),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
connector_response_reference_id: Some(item.response.data.id),
connector_response_reference_id: item.response.data.order_id.or(Some(connector_id)),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashh1215

}),
..item.data
})
Expand Down
Loading