Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement scylla traits for StrongSecret #6500

Merged
merged 6 commits into from
Nov 14, 2024
Merged

feat: implement scylla traits for StrongSecret #6500

merged 6 commits into from
Nov 14, 2024

Conversation

dracarys18
Copy link
Member

Type of Change

  • New feature

Description

This adds SerializeValue and FromCQL traits for masking StrongSecret

Motivation and Context

This is needed for Cassandra ORM to work

How did you test it?

** THIS CANNOT BE TESTED ON ENVIRONEMTS **
Compiler guided

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-framework Area: Framework S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 7, 2024
@dracarys18 dracarys18 added this to the October 2024 Release milestone Nov 7, 2024
@dracarys18 dracarys18 self-assigned this Nov 7, 2024
@dracarys18 dracarys18 requested a review from a team as a code owner November 7, 2024 06:34
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 7, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  Cargo.lock Unsupported file format
  crates/masking/Cargo.toml Unsupported file format
  crates/masking/src/cassandra.rs  0% smaller
  crates/masking/src/lib.rs  0% smaller

@dracarys18 dracarys18 linked an issue Nov 7, 2024 that may be closed by this pull request
feat: implement scylla cql traits for StrongSecret #6501
Closed
akshay-97
akshay-97 previously approved these changes Nov 7, 2024
View reviewed changes
SanchithHegde
SanchithHegde reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/masking/Cargo.toml Outdated Show resolved Hide resolved
akshay-97
akshay-97 previously approved these changes Nov 13, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 7d73e90 Nov 14, 2024
17 checks passed
@likhinbopanna likhinbopanna deleted the add_cassandra_masking branch November 14, 2024 09:25
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 17, 2024
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
@dracarys18 @hyperswitch-bot
feat: implement scylla traits for StrongSecret (#6500)
c765be1 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
@dracarys18 @hyperswitch-bot
feat: implement scylla traits for StrongSecret (#6500)
7f233ea 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay-97 akshay-97 akshay-97 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@dracarys18 dracarys18

Labels
A-framework Area: Framework
Projects
None yet
Milestone
November 2024 Release
Development

Successfully merging this pull request may close these issues.

feat: implement scylla cql traits for StrongSecret
4 participants
@dracarys18 @SanchithHegde @akshay-97 @likhinbopanna