Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change between v3.0.6 and v3.1.0 #551

Open
fpeterdev opened this issue Aug 13, 2024 · 1 comment
Open

Breaking change between v3.0.6 and v3.1.0 #551

fpeterdev opened this issue Aug 13, 2024 · 1 comment

Comments

@fpeterdev
Copy link

The signature of the hot() and cold() functions changed between versions 3.0.6 and 3.1.0.

It changed from:
cold(marbles: string, values?: any, error?: any):
to:
cold(marbles: string, values?: object, error?: object)

The any => object change can cause type errors
@grubeninspekteur
Copy link

Having this problem as well. Some of our error notifications are not objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grubeninspekteur @fpeterdev