Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes import order of custom.scss; puts at end #1010

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

deseo
Copy link
Contributor

@deseo deseo commented Oct 22, 2022

Closes #1009

This way, custom styles are able to override the callout styles, which were previously included last.

This way, custom styles are able to override the callout styles, which were previously included last.
@pdmosses pdmosses changed the title Closes #1009: Moved include directive for custom.sass to end Moved include directive for custom.sass to end Oct 22, 2022
@pdmosses
Copy link
Contributor

pdmosses commented Oct 22, 2022

@deseo Thanks for submitting this PR!

It's indeed good to link the PR to the issue it closes, but apparently the "closes" line has to be in the description, rather than the title. I've edited both accordingly, and the PR is now auto-linked to the issue.

BTW, @mattxwang is in charge of the preparations for v0.4.0, and he may adjust the title further when the PR gets merged.

Copy link
Contributor

@pdmosses pdmosses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The previous release v0.3.3 didn't include callouts, so this change can't break the previous behaviour.

@mattxwang mattxwang changed the title Moved include directive for custom.sass to end Fixed import order of custom.scss; puts at end Oct 24, 2022
@mattxwang mattxwang merged commit 53edd78 into just-the-docs:main Oct 24, 2022
@mattxwang mattxwang changed the title Fixed import order of custom.scss; puts at end Fixes import order of custom.scss; puts at end Oct 24, 2022
@mattxwang
Copy link
Member

Changelog:

Thanks for the contribution @deseo!

@pdmosses
Copy link
Contributor

@deseo I wrote:

The previous release v0.3.3 didn't include callouts, so this change can't break the previous behaviour.

I was wrong about that, unfortunately – see #1011. But I'm hopeful the workaround suggested there will fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom.sass should always be included last
3 participants