From c8fa634aca1b33c64b849d2a901eb23f67e006f9 Mon Sep 17 00:00:00 2001 From: martincostello Date: Wed, 17 Oct 2018 11:52:26 +0100 Subject: [PATCH 1/3] Freeze assembly version at major.0.0.0 Freeze the assembly version at major.0.0.0 (i.e. 4.0.0.0) to reduce binding redirects when strong-named. --- version.props | 1 + 1 file changed, 1 insertion(+) diff --git a/version.props b/version.props index 633987f0..bc5d4a1b 100644 --- a/version.props +++ b/version.props @@ -1,6 +1,7 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) + 4.0.0.0 4.0.0 From aad4a147326e00768fcbb9993b973de9098d1707 Mon Sep 17 00:00:00 2001 From: martincostello Date: Wed, 17 Oct 2018 11:53:09 +0100 Subject: [PATCH 2/3] Update NuGet metadata Use NuGet profile name as author. Use 64x64 package icon. Use comma as tag delimiter. --- Directory.Build.props | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index f92292b7..2d0158c1 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -9,7 +9,7 @@ $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb - Just Eat + JUSTEAT_OSS Just Eat Copyright (c) Just Eat 2015-$([System.DateTime]::Now.ToString(yyyy)) true @@ -18,12 +18,12 @@ latest $(MSBuildAllProjects);$(MSBuildThisFileFullPath) en-US - https://avatars3.githubusercontent.com/u/1516790?s=200 + https://avatars3.githubusercontent.com/u/1516790?s=64 https://github.com/justeat/JustEat.StatsD $(PackageProjectUrl)/blob/master/LICENSE $(PackageProjectUrl)/releases false - statsd;graphite;metrics;monitoring + statsd,graphite,metrics,monitoring true git $(PackageProjectUrl).git From 0d506a1b2408b97e069318142d5bbc75ab59439b Mon Sep 17 00:00:00 2001 From: martincostello Date: Wed, 17 Oct 2018 11:59:41 +0100 Subject: [PATCH 3/3] Strong name the assembly Strong-name the library, as recommended: https://docs.microsoft.com/en-gb/dotnet/standard/library-guidance/strong-naming --- Directory.Build.props | 3 +++ justeat-oss.snk | Bin 0 -> 596 bytes src/JustEat.StatsD/Properties/AssemblyInfo.cs | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 justeat-oss.snk diff --git a/Directory.Build.props b/Directory.Build.props index 2d0158c1..75977d8d 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -9,6 +9,7 @@ $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb + $(MSBuildThisFileDirectory)justeat-oss.snk JUSTEAT_OSS Just Eat Copyright (c) Just Eat 2015-$([System.DateTime]::Now.ToString(yyyy)) @@ -24,9 +25,11 @@ $(PackageProjectUrl)/releases false statsd,graphite,metrics,monitoring + true true git $(PackageProjectUrl).git + true true diff --git a/justeat-oss.snk b/justeat-oss.snk new file mode 100644 index 0000000000000000000000000000000000000000..65c3a7e0977f59a3f636bcaa9ef227683d91899d GIT binary patch literal 596 zcmV-a0;~N80ssI2Bme+XQ$aES1ONa50097^$}ZG~YT*6c79zs~P>% z9G7L};+pzI6PEv!H>YH_7{*6BJ2ebe*9M^b=s6Yf@=)$0>r{&{Fky$RXkTT@q=N(8 zhVYCWB-x$FNoFTJAbzTaaI`=GOn*tv^z3)MX%U7Ht}9d9eTu%cWy{S=(UAVHQF^Ug z+Gl*R(+dVj#{w^JS{yt74d*FQvE$Ic1%s<=Gp|L%G8@>a0bn%^>0JJ&@#8kkNW+sv z%;;XQ>vW!ZYs1}V;``_poRc6-Wc5>I~Kw@RG!$NbHEcO{|KtLYSODy zRA>CSE>gpJZdXE7p1bdtx!3Lzj6%pmg|8|Eb!l;?fr0h{TUZ}Vk^2kf_65wH+tBeK z`yC&EiO8Ywa~;2}{AG=_ATcMuXEo*}hKdj|=%ZYzD-IY#ljfmVE1UbtWtHZ)43Hs1 zDvY@sWPN8oF|&I$vYATVuP}}tG*@fJ%rOR7XfLEYs@VWP_nwd!z+W}vDb+3AH#S*52pqk=Z#YkbXOhzrDP zpS!u(T<~O5$+VLrUWNP9llXuxgOKS@s{SyMwqN~G0%wn9oD``C^x`!ka9#H