fix(remix): support Remix v2.9 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
haines
force-pushed
the
support-remix-2.9
branch
from
22b932b
to
828bea8
Compare
justindsmith
approved these changes
Apr 26, 2024
|
Thanks @haines! 😄 Just published 0.7.0 with your changes: https://www.npmjs.com/package/opentelemetry-instrumentation-remix/v/0.7.0 |
|
Awesome, thanks for the quick turnaround @justindsmith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In remix-run/remix#9142 the
RRsuffix was dropped fromcallRouteLoaderandcallRouteAction. This PR updates the Remix instrumentation so that it handles this change in v2.9.0.Note that this doesn't include supporting the new single fetch mode.