md-menu first implementation

[aminebizid]

This is a very basic implementation of md-menu.
Keep tuned :)

[Gregcop1]

blank line at the end of the file is missing

[Gregcop1]

First of all, thanks for you contribution. You may think that I've made a lot of comments but I think, you've used a lot of direct DOM manipulation instead of making use of Angular cool stuff, like templates, children reference, query, ...
May be you should write some tests during development. Sometimes it helps to see that if it's complicated to test, it's because the code is too complex.
Keep going! It's a "must have" feature :)

[aminebizid]

I didn't find how to append a child in Angular without using the DOM.

[Gregcop1]

To append a child to the body, you're right. MdDialog do the same thing, but IMO your container should be a component itself and all other dom manipulation (style, attribute, ...) should be made via templates and variable in this new component

[Gregcop1]

why changing tslint rules ? Current code is based on those rules

[aminebizid]

Sorry it's a mistake to commit tslint.json

Envoyé de mon iPhone

Le 26 avr. 2016 à 18:10, Grégory Copin notifications@github.com a écrit :

In tslint.json:

"rules": {

• "class-name": true,
• "comment-format": [true, "check-space"],
• "curly": true,
  why changing tsling rules ? Current code is based on those rules

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[aminebizid]

Ok I'll create a child template. I was avoiding that to make the code compact 1 component 1 template for basic menu.
This will make nested menus more complex.

[Gregcop1]

If it's an intern component, it's not more complex for the user, so it doesn't matter. But with a container append to body with overlay, one day, we can think of an unified component for all overlay (dialog, etc.). The more you rely on intern code, the more specific you are. May be we can think one step further.

[aminebizid]

Ok let's create a share container component for all popups and we put it in the body.

[justindujardin]

@Gregcop1 @Zigzag95 cool work! Before you go creating an overlay system, please consider using the @material2/core npm package. It includes an overlay system for exactly this purpose.

I plan to replace components with the official material2 implementations as they're available, so there's no conflict bringing in the core package now.

Please examine their portals and overlay core classes:
https://github.com/angular/material2/tree/master/src/core/portal
https://github.com/angular/material2/tree/master/src/core/overlay

The positioning strategy you will want to use for a menu is currently being reviewed here: angular/components#335

[Gregcop1]

So how do we procede? Should we include dependency to official overlay system ?

[justindujardin]

@Gregcop1 yes, let's do. I haven't used it yet so I can't recommend a way, but please investigate their demos and take a shot at it.

Please create a branch on the main repo to work on this. I have added @Zigzag95 as a collaborator so both of you may work on it together to make things easier.

Once you guys have a branch to work from, please close this PR and create a new one from that branch.

[zAPFy]

I have started some work on an autocomplete component. #202
I guess I could also use the Overlay class for that.
I will put the dev of autocomplete on hold as to not duplicate the effort.

[aminebizid]

WIP on overlay. It may take some days.
@core integration is not so trivial.

Envoyé de mon iPhone

Le 27 avr. 2016 à 18:08, Alexander Zeiher notifications@github.com a écrit :

I have started some work on an autocomplete component. #202
I guess I could also use the Overlay class for that.
I will put the dev of autocomplete on hold as to not duplicate the effort.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub