Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-pre-gyp binaries so people don't need node-gyp insanity? #126

Open
Pomax opened this issue Sep 17, 2017 · 5 comments
Open

node-pre-gyp binaries so people don't need node-gyp insanity? #126

Pomax opened this issue Sep 17, 2017 · 5 comments
Labels

Comments

@Pomax
Copy link

Pomax commented Sep 17, 2017

Heya,

would it be possible to generate a few common-modern-OS binaries (OSX 10.13/14, Win 10) and using node-pre-gyp to bypass compiling, so that people don't need to deal with the insanity that is node-gyp? Notably, node-gyp is incompatible with python 3, which in 2017 (edit: now 2019) is kind of... well I have words, and they're not kind so let's just say that this causes problems on systems that are for modern Python projects only.

There's a number of npm packages (the most notable one being sqlite3) that use pre-gyp to just pull a precompiled binary from AWS rather than compiling when the platform is known to have an already-built binary, and it makes life so much easier for anyone who wants to just write a program instead of spending 5 hours trying to make a build system work, after which they give up on the idea they had to begin with because their day got massively soured =)

@aumhaa
Copy link

aumhaa commented Aug 21, 2018

+1

1 similar comment
@RossJacobs
Copy link

+1

@dturner34
Copy link

I just installed python3 and this broke... :(
It would be nice to not depend on such a flaky dependency

@Pomax
Copy link
Author

Pomax commented Jul 6, 2022

then also make sure to upgrade node-gyp to 6.0 or higher (e.g. installing it yourself without saving it to your package.json), because it works just fine, but ancient versions of gyp have no idea what crazy versions of python the future uses. Look at the npm error report and if it says it's using node-gyp 5 or even older, that's why. And possibly look at your node version to make sure you're on 14 or higher (anything older is as dead as python 2.7)

@Julusian
Copy link

Julusian commented Oct 1, 2022

I have opened a PR to do an overhaul of this library which includes solving this (#228)
As it doesn't look like there are any maintainers around to merge it, I shall be maintaining a fork which is 100% api compatible https://www.npmjs.com/package/@julusian/midi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants