From 462cda400baa00b3bcc4a7f8aded362ca55e18a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90=E1=BB=97=20Tr=E1=BB=8Dng=20H=E1=BA=A3i?=
 <41283691+hainenber@users.noreply.github.com>
Date: Mon, 15 Jul 2024 22:34:38 +0700
Subject: [PATCH] fix(storybook): fix broken Storybook stories during
 development (#29587)

Signed-off-by: hainenber <dotronghai96@gmail.com>
---
 .../packages/superset-ui-demo/.storybook/preview.js           | 1 -
 .../legacy-preset-chart-nvd3/BoxPlot/stories/basic.tsx        | 4 ++--
 .../BoxPlot/{BoxPolot.stories.tsx => BoxPlot.stories.tsx}     | 0
 .../plugins/legacy-preset-chart-nvd3/src/transformProps.js    | 4 +++-
 .../src/components/CertifiedBadge/CertifiedBadge.stories.tsx  | 3 +++
 superset-frontend/webpack.config.js                           | 2 ++
 6 files changed, 10 insertions(+), 4 deletions(-)
 rename superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/BoxPlot/{BoxPolot.stories.tsx => BoxPlot.stories.tsx} (100%)

diff --git a/superset-frontend/packages/superset-ui-demo/.storybook/preview.js b/superset-frontend/packages/superset-ui-demo/.storybook/preview.js
index a82a6be715670..30e48845c0d38 100644
--- a/superset-frontend/packages/superset-ui-demo/.storybook/preview.js
+++ b/superset-frontend/packages/superset-ui-demo/.storybook/preview.js
@@ -55,7 +55,6 @@ export const parameters = {
 };
 
 // Superset setup
-
 configure();
 
 // Register color schemes
diff --git a/superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/BoxPlot/stories/basic.tsx b/superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/BoxPlot/stories/basic.tsx
index 19c01ed17b3d4..cf0bd8f656edf 100644
--- a/superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/BoxPlot/stories/basic.tsx
+++ b/superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/BoxPlot/stories/basic.tsx
@@ -24,8 +24,8 @@ import data from '../data';
 export const basic = () => (
   <SuperChart
     chartType="box-plot"
-    width={400}
-    height={400}
+    width={800}
+    height={600}
     datasource={dummyDatasource}
     queriesData={[{ data }]}
     formData={{
diff --git a/superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/BoxPlot/BoxPolot.stories.tsx b/superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/BoxPlot/BoxPlot.stories.tsx
similarity index 100%
rename from superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/BoxPlot/BoxPolot.stories.tsx
rename to superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/BoxPlot/BoxPlot.stories.tsx
diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/transformProps.js b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/transformProps.js
index 4287cd64c4ff9..4d2f6f2105880 100644
--- a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/transformProps.js
+++ b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/transformProps.js
@@ -111,7 +111,9 @@ export default function transformProps(chartProps) {
   const data = Array.isArray(rawData)
     ? rawData.map(row => ({
         ...row,
-        values: row.values.map(value => ({ ...value })),
+        values: Array.isArray(row.values)
+          ? row.values.map(value => ({ ...value }))
+          : row.values,
         key: formatLabel(row.key, datasource.verboseMap),
       }))
     : rawData;
diff --git a/superset-frontend/src/components/CertifiedBadge/CertifiedBadge.stories.tsx b/superset-frontend/src/components/CertifiedBadge/CertifiedBadge.stories.tsx
index af8e179d068d0..a248e7b0d1c1a 100644
--- a/superset-frontend/src/components/CertifiedBadge/CertifiedBadge.stories.tsx
+++ b/superset-frontend/src/components/CertifiedBadge/CertifiedBadge.stories.tsx
@@ -16,8 +16,11 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+import { configure as configureTranslation } from '@superset-ui/core';
 import CertifiedBadge, { CertifiedBadgeProps } from '.';
 
+configureTranslation();
+
 export default {
   title: 'CertifiedBadgeWithTooltip',
 };
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
index 20b1e8efc4020..3fbb413d9af40 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -75,6 +75,7 @@ if (!isDevMode) {
 const plugins = [
   new webpack.ProvidePlugin({
     process: 'process/browser.js',
+    ...(isDevMode ? { Buffer: ['buffer', 'Buffer'] } : {}), // Fix legacy-plugin-chart-paired-t-test broken Story
   }),
 
   // creates a manifest.json mapping of name to hashed output used in template files
@@ -336,6 +337,7 @@ const config = {
       fs: false,
       vm: require.resolve('vm-browserify'),
       path: false,
+      ...(isDevMode ? { buffer: require.resolve('buffer/') } : {}), // Fix legacy-plugin-chart-paired-t-test broken Story
     },
   },
   context: APP_DIR, // to automatically find tsconfig.json