Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature proposal] Delete Follow objects when the followed object is deleted? #521

Closed
David-Guillot opened this issue Dec 9, 2022 · 1 comment · Fixed by #523
Closed
Labels
future planned future features

Comments

@David-Guillot
Copy link
Contributor

Hi there,

In our use case we want to delete Follow objects when the followed object is deleted. We implemented that with Django pre_delete signal, and we thought that this piece of code was generic enough to maybe be integrated in actstream.

What do you think @justquick ? Maybe it could be conditioned to a setting if you don't want this behavior to be applied to everyone.

If you agree I can submit a PR today 😉

@justquick
Copy link
Owner

yes that seems like a great idea thanks! i notice i have put on_delete=models.CASCADE, in the follow model's gfk but that's only tied to the django content type model since its a gfk. looks like i tried to do what you all did and didnt do it right. please send me a pr w/ that signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future planned future features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants