Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Formatter loops sometimes #589

Closed
TungstnBallon opened this issue Jun 19, 2024 · 3 comments
Closed

[BUG] Formatter loops sometimes #589

TungstnBallon opened this issue Jun 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@TungstnBallon
Copy link
Contributor

Steps to reproduce

  1. Open YieldStrengthAndGrainSizeModel.jv in VS-Code with the jayvee extension >=v0.5.0-alpha enabled.
  2. go to line 28
  3. repeatedly press CTRL + SHIFT + I

Description

  • Expected: The formatter changes the code once
  • Actual: The formatter inserts and removes a newline
format_loop.webm
@TungstnBallon TungstnBallon added the bug Something isn't working label Jun 19, 2024
@georg-schwarz
Copy link
Member

Might be connected to eclipse-langium/langium#1550
A fix was released today with the latest Langium version, so an upgrade might solve our issue.

@TungstnBallon
Copy link
Contributor Author

Yes! I upgraded langium with npm install --save langium@latest langium-cli@latest, rebuilt the vs-code-extension and now it works

@rhazn rhazn mentioned this issue Jun 24, 2024
Closed
4 tasks
@georg-schwarz
Copy link
Member

Should be fixed by the Langium upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georg-schwarz @TungstnBallon