From a8d0b759edccfd7fda3b70c0bcc13e433d9dc617 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20Mu=CC=88ller?= Date: Tue, 3 Aug 2021 09:25:37 +0200 Subject: [PATCH 1/2] fix(newpattern): starter template use BEM correct condition remove default css remove namespace ( makes no sense this way ) --- lib/templates/README.md | 5 ++++- lib/templates/pattern.hbs | 4 ++-- lib/templates/pattern.js | 1 - lib/templates/pattern.module.scss | 6 ++---- lib/templates/pattern.ts | 1 - 5 files changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/templates/README.md b/lib/templates/README.md index ebdcaab..1ee382b 100644 --- a/lib/templates/README.md +++ b/lib/templates/README.md @@ -1,2 +1,5 @@ ## <%= filename %> -<% if (scss === false) { %>> Style can be found in global/style<% } %> \ No newline at end of file + +<% if (scss === false) { %>> Style can be found in global/style<% } %> + +Concept: [](https://) diff --git a/lib/templates/pattern.hbs b/lib/templates/pattern.hbs index 7159d92..c4483e3 100755 --- a/lib/templates/pattern.hbs +++ b/lib/templates/pattern.hbs @@ -1,4 +1,4 @@ -<{{tag}} {{#if id}}id="{{id}}" {{/if}} class="<%= classname %>{{#if modifiers}} {{modifiers}}{{/if}}{{#if xclasses}} {{xclasses}}{{/if}}" <% if (scss || js) { %> data-jsinit="<%= filename %>"<% } %>{{#if jsInstanceId}} data-module-id="{{jsInstanceId}}"{{/if}}{{#if xclasses}} {{{xattributes}}}{{/if}}> -
+<{{tag}} {{#if id}}id="{{id}}" {{/if}} class="<%= classname %>{{#if modifiers}} {{modifiers}}{{/if}}{{#if xclasses}} {{xclasses}}{{/if}}" <% if (scss || js) { %> data-jsinit="<%= filename %>"<% } %>{{#if jsInstanceId}} data-module-id="{{jsInstanceId}}"{{/if}}{{#if xattributes}} {{{xattributes}}}{{/if}}> +
diff --git a/lib/templates/pattern.js b/lib/templates/pattern.js index c4451cb..7119173 100755 --- a/lib/templates/pattern.js +++ b/lib/templates/pattern.js @@ -1,7 +1,6 @@ /** * init <%= filename %> * @alias <%= filename %> - * @namespace <%= namespace %> * @return {Object} <% if(js){ %>public methods and css bundle<% } %><% if (!js) { %>with css bundle<% } %> */ <% if (scss) { %> diff --git a/lib/templates/pattern.module.scss b/lib/templates/pattern.module.scss index 3367fdf..a94453c 100755 --- a/lib/templates/pattern.module.scss +++ b/lib/templates/pattern.module.scss @@ -3,11 +3,9 @@ */ .<%= classname %> { $-<%= type.charAt(0) %>: &; // A convenient shortcut to use with modifiers #{$-c}. example below - position: relative; - &-ct { - position: relative; - } + // &__ct { + // } // &--mdfClass { // #{$-c}-ct { diff --git a/lib/templates/pattern.ts b/lib/templates/pattern.ts index c071d8d..0fc607e 100644 --- a/lib/templates/pattern.ts +++ b/lib/templates/pattern.ts @@ -1,7 +1,6 @@ /** * init <%= filename %> * @alias <%= filename %> - * @namespace <%= namespace %> * @return {Object} <% if(js){ %>public methods and css bundle<% } %><% if (!js) { %>with css bundle<% } %> */ <% if (js) { %> From 01c031926bf9b031781082fd11f696a0b9218ab3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20Mu=CC=88ller?= Date: Thu, 5 Aug 2021 10:43:58 +0200 Subject: [PATCH 2/2] chore(version): bump to 2.4.3 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 43ce58f..0743ec3 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@jvmn/groundzero-taskrunner-webpack", - "version": "2.4.2", + "version": "2.4.3", "description": "Taskrunner for JvM/Neckar Groundzero projects", "keywords": [ "taskrunner",