-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't input "@" on German keyboard with <AltGr> #1681
Comments
Can confirm that this does not work with norwegian layout as well.
|
Does using Ctrl-AltGr work? |
@zacps no. |
Just for the record, it seems this only applies to windows. I can insert @ with AltGr+Q without any issues on linux. |
It certainly applies to macOS (10.13.x). |
Same here on French Azerty, none of the AltGr combinations are working |
I'm seeing a version of this on macOS with a UK keyboard. AltGr + the number keys gives me the expected characters (AltGr + 2 = €, AltGr + 4 = ¢) for every number... except for AltGr + 3, which should give a This key combination just does nothing at all. On the plus side, I guess I have an excuse not to comment my code any more. |
same here macos (just installed with brew)
|
This still persists on Windows 1809 with v0.2.5 and ConPTY but only in WSL, it works fine in PowerShell. Interestingly when running |
@niklas88 What output do you get when running |
macOS here (
|
@ncreuschling Since you're getting the On Windows it might be different, so it might be helpful to get confirmation if In the following is a patch which applies additional debug information. It would be helpful if anyone who runs into the issue, but diff --git a/src/input.rs b/src/input.rs
index be8ed0d..d0922cc 100644
--- a/src/input.rs
+++ b/src/input.rs
@@ -707,6 +707,8 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> {
self.ctx.write_to_pty(bytes);
*self.ctx.received_count() += 1;
+ } else {
+ println!("CHARACTER HAS BEEN SUPPRESSED: '{}'", c);
}
}
@@ -735,6 +737,7 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> {
};
if is_triggered {
+ println!("TRIGGERED BINDING {:?} FOR {:?}", input, binding);
// binding was triggered; run the action
binding.execute(&mut self.ctx, false);
has_binding = true;
Note: This can be applied simply by saving it to a file and running |
First of all - thank you for your effort. The patched Alacritty (against c541155) now prints:
Then:
I have not modified any settings in the |
@ncreuschling Looks like removing the Though I'm not entirely sure why I'd like some feedback on the Windows side of things, it would be interesting if this is caused by the same thing. @ncreuschling I've got another patch if you're willing to help out. It seems like the diff --git a/src/event.rs b/src/event.rs
index bada4f6..ea6f6b2 100644
--- a/src/event.rs
+++ b/src/event.rs
@@ -401,6 +401,7 @@ impl<N: Notify> Processor<N> {
processor.ctx.terminal.dirty = true;
},
KeyboardInput { input, .. } => {
+ println!("NEW KEYBOARD INPUT: {:?}", input);
processor.process_key(input);
if input.state == ElementState::Pressed {
// Hide cursor while typing
diff --git a/src/input.rs b/src/input.rs
index be8ed0d..d0922cc 100644
--- a/src/input.rs
+++ b/src/input.rs
@@ -707,6 +707,8 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> {
self.ctx.write_to_pty(bytes);
*self.ctx.received_count() += 1;
+ } else {
+ println!("CHARACTER HAS BEEN SUPPRESSED: '{}'", c);
}
}
@@ -735,6 +737,7 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> {
};
if is_triggered {
+ println!("TRIGGERED BINDING {:?} FOR {:?}", input, binding);
// binding was triggered; run the action
binding.execute(&mut self.ctx, false);
has_binding = true; Maybe that can get us a step closer to figuring out what exactly is going on. This should hopefully print the |
I might have confused you: Compilation is running, will report back… |
Here we go:
|
Oh, that changes everything. So there is no If there's no Looking at the key event of the From what I can tell we might need to fix this upstream and add a way to differentiate between AltGr and Alt as modifiers. Thanks for your help, this is likely the same on Windows! I'll think about possible work arounds and open an issue upstream (and link it here) if I don't find a solution. |
There is no Again, thank you. |
I've created rust-windowing/winit#756 for evaluating an upstream change to resolve this problem. There are alternative ways on how this can be resolved without requiring a change to winit, but I'd like to investigate an upstream approach first. |
Sorry it took me a bit to test this, I only have a Windows at work. I'm getting the following output for pressing
|
I got a bit further with this today while playing around with Alacritty on OS X again. It's not correct that the AltGr + 3 key combination does nothing at all -- I tried entering it in an Alacritty terminal containing a text-mode emacs instance, and emacs thought I'd entered This suggests that AltGr + 3 is correctly yielding a
For now I've added the following keybinding to my config as a temporary fix:
This works, but is not ideal because it doesn't differentiate between Right and Left Alt. Left Alt + another key should produce that key plus the Alt modifier; Right Alt plus another key should not. |
Indeed, this works for me when Thank you to everyone involved. |
Hi ncreuschling, Thanks! |
This was/is an entry in my |
Thank you for the quick response! |
doesn't work for me :( , proabably something wrong with my .alacritty.yml file. I didn't have one. Why was this closed, isn't this issue affecting every macos user? |
The problem ( |
Could you please post the path and content of that file? |
Please follow the instructions in the README.md. |
|
OMG. I'am very sorry, but i've posted to the wrong repo -.-. Forget what i was asking for. SORRY! |
No problem. |
I'm using alacritty on Windows with WSL via wslbridge (from wslttz 1.9.3)
On my Windows laptop I've got a German keyboard layout which has the right
<alt>
key called<AltGr>
and that is used to input"@"
via<AltGr> + <Q>
. However in alacritty that combination does nothing.The text was updated successfully, but these errors were encountered: