Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfaf scraper bugs #27

Open
5 of 8 tasks
jwnigel opened this issue Feb 2, 2023 · 2 comments
Open
5 of 8 tasks

pfaf scraper bugs #27

jwnigel opened this issue Feb 2, 2023 · 2 comments
Assignees

Comments

@jwnigel
Copy link
Owner

jwnigel commented Feb 2, 2023

  • Still getting this error sometime although search term works fine in browser: invalid literal for int() with base 10: ' ' ***Hardiness zone fixed this issue. I think it was zones >= 10 throwing error. ***Using float() instead of int() also.

  • Height is returning the string 'to' sometimes. I noticed it in Onion and Rosemary.

  • In Habitat (maybe others), remove pfaf references in square brackets [] Example: 'Rich fertile woods and hillsides[43, 82] in deep well-drained soils[229].' (Although maybe this is necessary for liscensing?

  • Clean up output in general: Sometimes strings like "perennial" are returned in all caps. Make things consistent.

  • Use regex to grab hardiness zones. Current [-1] indexing doesn't work when zones >= 10

  • Add pollinators to scraper

  • When scraping varieties like Acer saccharum var nigra, the search string should be 'Acer+saccharum+nigra', without 'var'

  • plant_type has bugs that need to be fixed #32

@jwnigel jwnigel self-assigned this Feb 2, 2023
@jwnigel
Copy link
Owner Author

jwnigel commented Feb 2, 2023

Should I be adding minor issues like this to our milestone or keep them seperate? @berteh
I am working on the milestone when these things come up.

@berteh
Copy link
Collaborator

berteh commented Feb 2, 2023

if you plan on fixing them some day then yes, I'd create an issue as a reminder, and link the issue to the existing milestone that would need that issue to be fixed.

plus it's quite satisfactory to close an issue down the road, hitting the "done" button.

if you feel like that issue is quite easy to solve you can add the label "good first issue", just in case somebody else finds the project and gets interested to contribute.

@jwnigel jwnigel added this to the 0.1 internal data structure milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants