Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plant width estimator function #28

Open
jwnigel opened this issue Feb 2, 2023 · 2 comments
Open

Create plant width estimator function #28

jwnigel opened this issue Feb 2, 2023 · 2 comments

Comments

@jwnigel
Copy link
Owner

jwnigel commented Feb 2, 2023

Many of the "Width" entries in pfaf are null, and it is essential to create the design.

So we need to create a reasonably accurate width estimator (Finally get to use some data analysis skills) :)
My initial idea is to create a height-width ratio for all plants. I assume trees have a larger ratio (more heigth to width) than shrubs so we could return a different ratio for different plants. Or look at the heigh-width ratio of members in the taxonomic family?

@jwnigel jwnigel added this to the 0.1 internal data structure milestone Feb 2, 2023
@berteh
Copy link
Collaborator

berteh commented Feb 2, 2023

I'd rather keep it empty in the data, so we don't fill wrong data with no means of knowing what's accurate and what's a computed approximation.

But you're right the behavior needs one to be able to display and that's where the accessor method would still return a value when the data is empty, either default or half the height, for instance... but not populate the data and maybe even logging somewhere that this info is missing... for some day prompting the user to look it up and then correct the data.

@jwnigel
Copy link
Owner Author

jwnigel commented Feb 2, 2023

Yes, great point that we don't want to fill the data.

I'll create a width method, for now in the design_data_class notebook to fill in when null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants