feat(project): add meta tag for GA #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbudzins
reviewed
Jul 5, 2023
.env
Outdated
| @@ -6,3 +6,5 @@ APP_DEFAULT_LANGUAGE=en | |||
|
|
|||
| # a comma separated list of languages that are enabled (this only works for languages that are enabled in the app) | |||
| APP_ENABLED_LANGUAGES=en,es | |||
|
|
|||
| APP_GOOGLE_SITE_VERIFICATION_ID=joKVm0-rBn0Xqsqrdu_MPgQU2_jJvKSnqwEwodBvnhk | |||
There was a problem hiding this comment.
Let's not include it in the .env file (because that will get picked up by any forked repos) and instead still feed it in via vars and env in the github action. It's not a sensitive value, but nice to implement in a way that other developers can fork and set their own values without create git noise.
|
Visit the preview URL for this PR (updated for commit 0ee3686): https://ottwebapp--pr330-feat-add-meta-tag-fo-8f9ud6mf.web.app (expires Sat, 05 Aug 2023 11:35:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
dbudzins
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add meta tag for GA
This PR solves BC-570
Steps completed:
According to our definition of done, I have completed the following steps: