fix: only remove token from hash after login with social media #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirovladimitrovski
requested review from
ChristiaanScheermeijer,
dbudzins and
royschut
mirovladimitrovski
changed the title
|
Visit the preview URL for this PR (updated for commit 6d3c449): https://ottwebapp--pr499-owa-74-only-remove-t-o7m3qo9c.web.app (expires Sat, 18 May 2024 19:18:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
mirovladimitrovski
changed the title
8 tasks
packages/ui-react/src/containers/AccountModal/forms/PersonalDetails.tsx
Outdated
Show resolved
Hide resolved
packages/ui-react/src/containers/AccountModal/forms/PersonalDetails.tsx
Outdated
Show resolved
Hide resolved
packages/ui-react/src/containers/AccountModal/forms/PersonalDetails.tsx
Outdated
Show resolved
Hide resolved
mirovladimitrovski
requested review from
ChristiaanScheermeijer and
AntonLantukh
packages/ui-react/src/containers/AccountModal/forms/PersonalDetails.tsx
Outdated
Show resolved
Hide resolved
ChristiaanScheermeijer
approved these changes
Apr 17, 2024
|
Don't forget to squash and give the commit(s) a nice name for the changelogs 😄 I think the changelog parser skips the |
AntonLantukh
changed the title
mirovladimitrovski
requested review from
AntonLantukh
and removed request for
AntonLantukh
AntonLantukh
approved these changes
Apr 18, 2024
AntonLantukh
approved these changes
Apr 19, 2024
AntonLantukh
pushed a commit
that referenced
this pull request
Apr 22, 2024
…n with social media (#499)
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves OWA-74.
Steps completed:
According to our definition of done, I have completed the following steps: