Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): Fix watchlist flaky test #50

Merged
merged 1 commit into from
May 3, 2022

Conversation

AntonLantukh
Copy link
Collaborator

@AntonLantukh AntonLantukh commented May 2, 2022

Add scroll to solve the problem with playlist click.
Changes also include formatting fixes. I will fix the rest in a separate PR.

This PR solves #45

Steps completed:

According to our definition of done, I have completed the following steps:

  • User stories met
  • Storybook stories
  • Unit tests added
  • Linting passing
  • Unit tests passing
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@AntonLantukh AntonLantukh force-pushed the bug/fix-watchlist-flaky-test branch from 2f84f0d to 8fcb883 Compare May 2, 2022 14:46
Add scroll to solve the problem with playlist click
@AntonLantukh AntonLantukh force-pushed the bug/fix-watchlist-flaky-test branch from 8fcb883 to fb6fc47 Compare May 2, 2022 14:47
@AntonLantukh
Copy link
Collaborator Author

This one was really tricky. The e2e-engine manages to click in every case but the click stage gets failed state. I noticed some strange behaviour while scrolling to the Continue Watching section (seems to be kind of resizing), so I added manual scrolling to the necessary element. No it should work fine.

@AntonLantukh AntonLantukh requested a review from dbudzins May 2, 2022 18:57
@AntonLantukh AntonLantukh marked this pull request as ready for review May 2, 2022 18:58
@AntonLantukh AntonLantukh changed the title fix(project): fix watchlist flaky test fix(project): Fix watchlist flaky test May 2, 2022
Copy link
Contributor

@dbudzins dbudzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... thanks for debugging this!

@AntonLantukh AntonLantukh merged commit 1974614 into develop May 3, 2022
@AntonLantukh AntonLantukh linked an issue May 5, 2022 that may be closed by this pull request
@dbudzins dbudzins deleted the bug/fix-watchlist-flaky-test branch November 10, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Flaky Watchlist Test
2 participants