fix: update plan types and access bridge port for the unit test workflow #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiremitrov123
requested review from
AntonLantukh and
dbudzins
as code owners
|
Visit the preview URL for this PR (updated for commit 9073939): https://ottwebapp--pr619-fix-access-bridge-ty-t0euk43e.web.app (expires Wed, 23 Oct 2024 10:57:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
darkoatanasovski
approved these changes
Sep 23, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small type corrections is needed in order to match the required Plans structure for the opened PRs.
Also, the unit test workflow is failing due to port already in use, I assume updating the access bridge to use another port will resolve that.
This PR solves # .
Steps completed:
According to our definition of done, I have completed the following steps: