Feat: Update config to support new schema #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
4 times, most recently
from
8fdaa69 to
88d8c7d
Compare
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
88d8c7d to
c99506d
Compare
- New config schema changes - Existing configs modifications (main config + configs we use for e2e) - Validations rules change - Continue Watching is now shown if we add it to content array property with a special type - Showaces notions changes to app / app-config - Add new 'type' property to PlaylistContainer to deal with 'continue_watching' and 'favorites' - Add custom shelf title This commit breaks backward compatibility. Old config versions are not supported anymore
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
c99506d to
1493b40
Compare
dbudzins
reviewed
May 30, 2022
dbudzins
reviewed
May 30, 2022
dbudzins
reviewed
May 30, 2022
dbudzins
reviewed
May 30, 2022
added 2 commits
May 31, 2022 10:24
- Cleeng getter added to config store - New error support for playlists without contentId and type This commit breaks backward compatibility. Old config versions are not supported anymore
- New config schema changes - Existing configs modifications (main config + configs we use for e2e) - Validations rules change - Continue Watching is now shown if we add it to content array property with a special type - Showcases notions changes to app / app-config - Add new 'type' property to PlaylistContainer to deal with 'continue_watching' and 'favorites' - Add custom shelf title This commit breaks backward compatibility. Old config versions are not supported anymore
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
392db57 to
1b33d7d
Compare
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
44f7dd5 to
d0a3312
Compare
dbudzins
approved these changes
May 31, 2022
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
137a879 to
badc3c7
Compare
src/hooks/useOffers.ts
Outdated
Comment on lines
16
to
18
| } = useConfigStore(({ getCleengData, accessModel }) => ({ cleeng: getCleengData(), accessModel })); | ||
| } = useConfigStore(({ getCleengData, accessModel }) => ({ cleeng: getCleengData(), accessModel }), shallow); | ||
|
|
||
| console.warn(cleengSandbox, monthlyOfferId, yearlyOfferId); |
There was a problem hiding this comment.
Committed by accident?
There was a problem hiding this comment.
Thanks! Fixed it now
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
badc3c7 to
774436a
Compare
- Add new version - Minor fixes Breaking changes
AntonLantukh
force-pushed
the
feature/support-new-config-type
branch
from
774436a to
1b53e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit breaks backward compatibility. Old config versions are not supported anymore
Description
This PR solves #58
Steps completed:
According to our definition of done, I have completed the following steps: