854 jdk17 visibility #855
Merged
854 jdk17 visibility #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced ByteArrayInputStream reflection with new BytesInputStream implementation. The reflection is what required --add-opens java.base/java.io=jjwt.api on JDK 17+. - Refactored KeysBridge to perform our own key length logic instead of delegating to sun.security.util.KeyUtil. The reflection is what required --add-opens java.base/sun.security.util=jjwt.api on JDK 17+ - Removed AddOpens.java due to above refactoring (no longer needed).
- Replaced ByteArrayInputStream reflection with new BytesInputStream implementation. The reflection is what required --add-opens java.base/java.io=jjwt.api on JDK 17+. - Refactored KeysBridge to perform our own key length logic instead of delegating to sun.security.util.KeyUtil. The reflection is what required --add-opens java.base/sun.security.util=jjwt.api on JDK 17+ - Removed AddOpens.java due to above refactoring (no longer needed). - Returned a test-only --add-opens for sun.security.util for 3 test cases (added to test.addOpens maven property)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #854.
Replaced
ByteArrayInputStreamreflection with newBytesInputStreamimplementation. The reflection is what required--add-opens java.base/java.io=jjwt.apion JDK 17+.Refactored
KeysBridgeto perform our own key length logic instead of delegating tosun.security.util.KeyUtil. The reflection is what required--add-opens java.base/sun.security.util=jjwt.apion JDK 17+Removed
AddOpens.javadue to above refactoring (no longer needed).