Skip to content

Latest commit

 

History

History
134 lines (85 loc) · 4.56 KB

CONTRIBUTING.rst

File metadata and controls

134 lines (85 loc) · 4.56 KB
Raw

Contributing

  1. Please sign one of the contributor license agreements below.
  2. Fork the repo, develop and test your code changes, add docs.
  3. Make sure that your commit messages clearly describe the changes.
  4. Send a pull request.

Here are some guidelines for hacking on google-auth-library-python.

Making changes

A few notes on making changes to google-auth-library-python.

  • If you've added a new feature or modified an existing feature, be sure to add or update any applicable documentation in docstrings and in the documentation (in docs/). You can re-generate the reference documentation using nox -s docgen.
  • The change must work fully on the following CPython versions: 2.7, 3.5, 3.6, 3.7 across macOS, Linux, and Windows.
  • The codebase must have 100% test statement coverage after each commit. You can test coverage via nox -e cover.

Testing changes

To test your changes, run unit tests with nox:

$ nox -s unit

Running system tests

You can run the system tests with nox:

$ nox -f system_tests/noxfile.py

To run a single session, specify it with nox -s:

$ nox -f system_tests/noxfile.py -s service_account

To run system tests locally, you will need to set up a data directory

$ mkdir system_tests/data

Add a service account file and authorized user file to the data directory. Your directory should look like this

system_tests/
    data/
      service_account.json
      authorized_user.json

The files must be named exactly service_account.json and authorized_user.json. See Creating and Managing Service Account Keys for how to obtain a service account.

Use the gcloud CLI to get an authorized user file

$ gcloud auth application-default login --scopes=https://www.googleapis.com/auth/userinfo.email,https://www.googleapis.com/auth/cloud-platform,openid

You will see something like:

Credentials saved to file: [/usr/local/home/.config/gcloud/application_default_credentials.json]```

Copy the contents of the file to authorized_user.json.

App Engine System Tests

To run the App Engine tests, you wil need to deploy a default App Engine service. If you already have a default service associated with your project, you can skip this step.

Edit app.yaml so service is default instead of google-auth-system-tests. From system_tests/app_engine_test_app run the following commands

$ pip install --target-lib -r requirements.txt
$ gcloud app deploy -q app.yaml

After the app is deployed, change service in app.yaml back to google-auth-system-tests. You can now run the App Engine tests:

$ nox -f system_tests/noxfile.py -s app_engine

Coding Style

This library is PEP8 & Pylint compliant. Our Pylint config is defined at pylintrc for package code and pylintrc.tests for test code. Use nox to check for non-compliant code:

$ nox -s lint

Documentation Coverage and Building HTML Documentation

If you fix a bug, and the bug requires an API or behavior modification, all documentation in this package which references that API or behavior must be changed to reflect the bug fix, ideally in the same commit that fixes the bug or adds the feature.

To build and review docs use nox:

$ nox -s docs

The HTML version of the docs will be built in docs/_build/html

Versioning

This library follows Semantic Versioning.

It is currently in major version zero (0.y.z), which means that anything may change at any time and the public API should not be considered stable.

Contributor License Agreements

Before we can accept your pull requests you'll need to sign a Contributor License Agreement (CLA):

  • If you are an individual writing original source code and you own the intellectual property, then you'll need to sign an individual CLA.
  • If you work for a company that wants to allow you to contribute your work, then you'll need to sign a corporate CLA.

You can sign these electronically (just scroll to the bottom). After that, we'll be able to accept your pull requests.