Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multipart/form-data #12

Merged
merged 2 commits into from
Nov 14, 2020
Merged

Conversation

natsuokawai
Copy link
Contributor

@natsuokawai natsuokawai commented Nov 13, 2020

Currently multipart/form-data in ( request | response ) body is not supported.

スクリーンショット 2020-11-13 17 21 05

According to the document, multipart/form-data is described as type: string, format: binary.
https://swagger.io/docs/specification/describing-request-body/file-upload/

I'm not sure if this is the right way to determine multipart/form-data in the build_type method, is this implementation acceptable?

I also think the example needs to be handled well because there's a lot of unnecessary information.

@k0kubun
Copy link
Collaborator

k0kubun commented Nov 14, 2020

Hmm, your test runs successfully in my local environment, but CI is not happy about it for some reason.

@k0kubun
Copy link
Collaborator

k0kubun commented Nov 14, 2020

Ah, no, I just forgot switching the branch. I reproduced the failure.

I'm not sure if this is the right way to determine multipart/form-data in the build_type method, is this implementation acceptable?

I also think the example needs to be handled well because there's a lot of unnecessary information.

Agreed. Though it's probably better than crashing it with NotImplementedError. So let me merge this for now.

@k0kubun k0kubun merged commit 6977b2d into exoego:master Nov 14, 2020
@natsuokawai
Copy link
Contributor Author

Thank you🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants