Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application version field #16

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Add application version field #16

merged 4 commits into from
Jan 12, 2021

Conversation

jorbs
Copy link
Contributor

@jorbs jorbs commented Jan 12, 2021

Currently, the version field doesn't output to the generated YAML file and, as OpenAPI specification states, it is a required field. See https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#fixed-fields-1.

Also, when we try to import the YAML into Postman, it throws format not recognized because there is no version field on the output file.

So this PR let's the user specify an application version to be set in the YAML file and use 1.0.0 as default.

Copy link
Collaborator

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k0kubun k0kubun merged commit 74f2671 into exoego:master Jan 12, 2021
@jorbs jorbs deleted the feature/version-field branch January 12, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants