Created setting to generate output as JSON #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
approved these changes
Oct 11, 2021
bf4
reviewed
Oct 11, 2021
bf4
reviewed
Oct 11, 2021
| @@ -38,4 +51,8 @@ def prepend_comment(content) | |||
| end | |||
| "#{comment.gsub(/^/, '# ').gsub(/^# \n/, "#\n")}#{content}" | |||
| end | |||
|
|
|||
| def json? | |||
| RSpec::OpenAPI.output.to_s == 'json' | |||
There was a problem hiding this comment.
arguably instead it should check File.extname(@path) == ".json" and rely on that
There was a problem hiding this comment.
Good call. I did so in v0.4.0 25f0798.
There was a problem hiding this comment.
Really your alternative is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the option to generate the output as JSON.
Only configure the option
RSpec::OpenAPI.output = :jsonand the content will generate the json content.Could you add the label
hacktoberfestto your repository, I would be very grateful?