Add the version constraint for actionpack #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#38 introduced the check whether the route comes from Rails with `route.app.engine?`. However, the method `engine?` was added in this PR, and this is available since Rails 5.2. rails/rails@b50e88e So, adding the version constraint might make sense. Note Rails 5.2 reached EOL, which means patches against severe security issues will not be available, so I added `>= 6.0.0` instead of `>= 5.2.0`.
|
I don't intend to maintain EOL Rails compatibility, but I don't find a strong motivation to drop Rails 5.2 compatibility either. If you only need |
|
Thank you for your feedback. I updated with de9bb86. |
k0kubun
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38 introduced the check whether the route comes from Rails with
route.app.engine?.However, the method
engine?was added in this commit, and this is available since Rails 5.2.So, adding the version constraint might make sense.
Note Rails 5.2 reached EOL, which means patches against
severe security issues will not be available, so I added
>= 6.0.0instead of>= 5.2.0.