Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some wrapped errors are not working #132

Closed
kke opened this issue Nov 7, 2023 · 1 comment
Closed

Some wrapped errors are not working #132

kke opened this issue Nov 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kke
Copy link
Contributor

kke commented Nov 7, 2023

Anything returned from NewClientConn in crypto/ssh will "flatten" wrapped errors. There is an issue and a PR at golang/go#61309 golang/crypto#266

This makes some of rig's error wrapping lose all meaning and for example makes k0sctl's retry not give up before the timeout, because using errors.Is(err, rig.ErrCantConnect) is never true.
@kke kke added the bug Something isn't working label Nov 7, 2023
@kke kke mentioned this issue Nov 8, 2023
Merged
@kke
Copy link
Contributor Author

kke commented Dec 19, 2023

Fixed in crypto 0.17.0

@kke kke closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kke