We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I noticed that the current implementation of multipart/form-data attempts to read a file if the specified form value is a string.
multipart/form-data
https://github.com/k1LoW/runn/blob/10bfec2fc03d0bd49d9c0bda14f08fffcdbca39e/http.go#L256:L271
This implementation caused some errors for me, and I believe the behavior can be improved by introducing a file:// prefix.
file://
Introducing a file:// prefix could help address these issues and make the behavior more explicit and reliable.
The text was updated successfully, but these errors were encountered:
@h6ah4i Thank you for your proposal!
Indeed, it is better to introduce file:// prefix to check files strictly.
However, I would like to keep the current behavior without prefix at the side.
This is partly for backward compatibility, but also because I want to match the behavior of other path resolution.
So, how about making it so that files are only checked strictly when a file:// prefix is added?
Then we can introduce file:// prefix in other path resolution implementations in the future.
Sorry, something went wrong.
@k1LoW Preserving backward compatibility is an important concern as well. I agree with the direction you're taking! 👍
Released as v0.122.0 👍
No branches or pull requests
Hi, I noticed that the current implementation of
multipart/form-data
attempts to read a file if the specified form value is a string.https://github.com/k1LoW/runn/blob/10bfec2fc03d0bd49d9c0bda14f08fffcdbca39e/http.go#L256:L271
This implementation caused some errors for me, and I believe the behavior can be improved by introducing a
file://
prefix.Introducing a
file://
prefix could help address these issues and make the behavior more explicit and reliable.The text was updated successfully, but these errors were encountered: