Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property 'options' is private #360

Closed
samizarraa opened this issue Sep 30, 2020 · 4 comments · Fixed by #364
Closed

Property 'options' is private #360

samizarraa opened this issue Sep 30, 2020 · 4 comments · Fixed by #364
Assignees
@k3nsei
Labels
bug Hacktoberfest

Comments

@samizarraa
Copy link

samizarraa commented Sep 30, 2020 •
edited
Loading

Hi, I have this issue:
Property 'options' is private and only accessible within class 'InViewportDirective'.
[inViewportOptions]="{ threshold: [0] }"

"ng-in-viewport": "^6.1.3"
Angular 10: Strict Mode
@k3nsei k3nsei self-assigned this Oct 3, 2020
@k3nsei k3nsei mentioned this issue Oct 3, 2020
Merged
@k3nsei
Copy link
Owner

k3nsei commented Oct 3, 2020

Fixed and will be released in near future

@k3nsei
Copy link
Owner

k3nsei commented Oct 3, 2020

@all-contributors please add @samizarraa for bug

@allcontributors allcontributors bot mentioned this issue Oct 3, 2020
Merged
@allcontributors
Copy link
Contributor

@k3nsei

I've put up a pull request to add @samizarraa! 🎉

@samizarraa
Copy link
Author

@k3nsei

I've put up a pull request to add @samizarraa! 🎉

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k3nsei k3nsei

Labels
bug Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make options input public k3nsei/ng-in-viewport
2 participants
@k3nsei @samizarraa