Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd-snapshot-cron flag help text incorrect #6752

Closed
brandond opened this issue Jan 14, 2023 · 1 comment
Closed

etcd-snapshot-cron flag help text incorrect #6752

brandond opened this issue Jan 14, 2023 · 1 comment
Assignees
Milestone

Comments

@brandond
Copy link
Member

In the case of "* */5 * * *", it runs every minute past every 5 hours, so it is not true that it runs every 5 hours.
To solve it set 0 as minutes (0 */5 * * *)

@VestigeJ
Copy link

VestigeJ commented Feb 7, 2023

This validation isn't super serious because both the previous and now the new example for cron are valid cron schedules.

##Environment Details
COMMIT=ee007bc7cf6b44f863ec0767a6f3155dbd90d54c

Infrastructure

  • Cloud

Node(s) CPU architecture, OS, and version:

Linux 5.14.21-150400.24.11-default x86_64 GNU/Linux
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP4"

Cluster Configuration:

NAME              STATUS   ROLES                       AGE   VERSION
ip-222-33-33-44   Ready    control-plane,etcd,master   12m   v1.26.1+k3s-ee007bc7 

Config.yaml:

write-kubeconfig-mode: 644
debug: true
token: mango
cluster-init: true
snapshot-compress: true
etcd-snapshot-retention: 18
etcd-snapshot-schedule-cron: "*/1 * * * *" //additionally tested "0/1 * * * *"

YOUR_REPRODUCED_RESULTS_HERE

$ curl https://get.k3s.io --output install-"k3s".sh
$ sudo chmod +x install-"k3s".sh
$ sudo groupadd --system etcd && sudo useradd -s /sbin/nologin --system -g etcd etcd
$ sudo modprobe ip_vs_rr
$ sudo modprobe ip_vs_wrr
$ sudo modprobe ip_vs_sh
$ sudo printf "on_oovm.panic_on_oom=0 \nvm.overcommit_memory=1 \nkernel.panic=10 \nkernel.panic_ps=1 \nkernel.panic_on_oops=1 \n" > ~/90-kubelet.conf
$ sudo cp 90-kubelet.conf /etc/sysctl.d/
$ sudo systemctl restart systemd-sysctl
$ COMMIT=ee007bc7cf6b44f863ec0767a6f3155dbd90d54c
$ sudo INSTALL_K3S_COMMIT=$COMMIT INSTALL_K3S_EXEC=server ./install-k3s.sh
$ w2 sudo ls -lahr /var/lib/rancher/k3s/server/db/snapshots/ //watch -n 2 snapshots directory


**Results:**

$ sudo ls /var/lib/rancher/k3s/server/db/snapshots/

etcd-snapshot-ip-222-33-33-44-1675730044 etcd-snapshot-ip-222-33-33-44-1675730401 etcd-snapshot-ip-222-33-33-44-1675730762
etcd-snapshot-ip-222-33-33-44-1675730100 etcd-snapshot-ip-222-33-33-44-1675730463 etcd-snapshot-ip-222-33-33-44-1675730821
etcd-snapshot-ip-222-33-33-44-1675730162 etcd-snapshot-ip-222-33-33-44-1675730523 etcd-snapshot-ip-222-33-33-44-1675730881
etcd-snapshot-ip-222-33-33-44-1675730224 etcd-snapshot-ip-222-33-33-44-1675730582 etcd-snapshot-ip-222-33-33-44-1675730940
etcd-snapshot-ip-222-33-33-44-1675730282 etcd-snapshot-ip-222-33-33-44-1675730641 etcd-snapshot-ip-222-33-33-44-1675731000
etcd-snapshot-ip-222-33-33-44-1675730342 etcd-snapshot-ip-222-33-33-44-1675730701 etcd-snapshot-ip-222-33-33-44-1675731063


</details>

@VestigeJ VestigeJ closed this as completed Feb 7, 2023
@github-project-automation github-project-automation bot moved this from To Test to Done Issue in K3s Development Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants