[1.30] Remove deprecated kublet flag pod-infra-container-image

[dereknola]

Is your feature request related to a problem? Please describe.

Running K3s with --pause-image=:"rancher/mirrored-pause:3.5" produces logs with:

Flag --pod-infra-container-image has been deprecated, will be removed in a future release. Image garbage collector will     get sandbox image information from CRI.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

kubernetes/kubernetes#106893

[dereknola]

The upstream issue is still tracking as incomplete.

[dereknola]

Update: Upstream is on track to no-op the argument in 1.29, with remove in 1.30+

[dereknola]

Upstream bumping it out to "future release" during 1.27 development. kubernetes/kubernetes@a1def4b

Later it was supposed to be 1.29, but cri-dockerd was still not ready, so now its 1.30

[afbjorklund]

The flag doesn't do anything in 1.29, so the kubelet now tries to garbage collect the pause image for docker...

But most of the time, there is some pod or other still using it - so that won't make much of a difference in practice.

[brandond]

The pause image is supposed to get pinned via CRI if the runtime supports it. I'm not sure that cri-dockerd does yet though.

[afbjorklund]

I made a quick hack for it, but it got stuck in CI due to the missing API (since it only did k8s 1.22 at the time)

• Return the sandbox image status as "Pinned" Mirantis/cri-dockerd#194

[brandond]

Thanks! If upstream doesn't merge that, we might pull it into our fork.

[rancher-max]

Validated using v1.30.0-rc2+k3s1 and v1.30.0-rc2+rke2r1

This log warning is no longer present. See only deprecation warning remaining:

$ journalctl -eu k3s | grep -i deprecated
May 08 19:14:42 max1 k3s[4500]: Flag --containerd has been deprecated, This is a cadvisor flag that was mistakenly registered with the Kubelet. Due to legacy concerns, it will follow the standard CLI deprecation timeline before being removed.

config.yaml used:

write-kubeconfig-mode: 644
selinux: true
cluster-init: true
pause-image: rancher/mirrored-pause:3.5