Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerd aufs/devmapper/zfs snapshotters removed from May 2023 releases #7660

Closed
fidencio opened this issue Jun 1, 2023 · 4 comments
Closed
Assignees
Milestone

Comments

@fidencio
Copy link

fidencio commented Jun 1, 2023

Some VM based workloads do not have the capability of using a shared filesystem to give the guest access to the container rootfs, which is stored on the host side.

This case described above is exactly what happens when we talk about Kata Containers using Firecracker as VMM, Kata Containers running Confidential VMs (such as Intel TDX, AMD SEV, AMD SNP, IBM SE).

Enabling this on the k3s side is an onliner, here:

_ "github.com/containerd/containerd/snapshots/btrfs/plugin"

Having this enabled by default would help a lot users of VM based workloads.

@brandond
Copy link
Member

brandond commented Jun 5, 2023

Just noting here that we did have a long series of releases that included the zfs snapshotter. That was unintentionally added when we moved to building standalone containerd, so we didn't initially notice when it went away when we moved containerd back into the multicall binary. Some folks had come to rely on its presence.

@wenerme
Copy link

wenerme commented Jun 5, 2023

I can accept migrate off zfs snapshotter to zfs vol if I know how, (zfs 2.2 support overlayfs), but before this, I hope I can use the stable version of k3s 😭

@brandond
Copy link
Member

brandond commented Jun 5, 2023

This will be resolved in the June releases.

@brandond brandond changed the title snapshotters: Would it be possible to have devmapper snapshotter enabled? Containerd snapshotters missing in May 2023 releases Jun 5, 2023
@brandond brandond changed the title Containerd snapshotters missing in May 2023 releases Containerd aufs/devmapper/zfs snapshotters removed from May 2023 releases Jun 5, 2023
@brandond brandond moved this from Peer Review to To Test in K3s Development Jun 8, 2023
@ShylajaDevadiga ShylajaDevadiga self-assigned this Jun 9, 2023
@ShylajaDevadiga
Copy link
Contributor

Validated using commit id b66a118 from master branch

  • Plugins are being loaded on startup.

skip loading plugin due to non zfs filesystem

> sudo ctr plugin ls | grep snapshotter
io.containerd.snapshotter.v1           aufs                     linux/amd64    skip      
io.containerd.snapshotter.v1           btrfs                    linux/amd64    skip      
io.containerd.snapshotter.v1           devmapper                linux/amd64    error     
io.containerd.snapshotter.v1           native                   linux/amd64    ok        
io.containerd.snapshotter.v1           overlayfs                linux/amd64    ok        
io.containerd.snapshotter.v1           fuse-overlayfs           linux/amd64    ok        
io.containerd.snapshotter.v1           stargz                   linux/amd64    ok        
io.containerd.snapshotter.v1           zfs                      linux/amd64    skip  
> sudo grep type=io.containerd.snapshotter.v1 /var/lib/rancher/k3s/agent/containerd/containerd.log |grep plugin
time="2023-06-14T16:57:42.584757200Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.aufs\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.587577630Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.aufs\"..." error="aufs is not supported (modprobe aufs failed: exit status 1 \"modprobe: FATAL: Module aufs not found in directory /lib/modules/5.3.18-59.37-default\\n\"): skip plugin" type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.587607306Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.btrfs\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.587918584Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.btrfs\"..." error="path /var/lib/rancher/k3s/agent/containerd/io.containerd.snapshotter.v1.btrfs (xfs) must be a btrfs filesystem to be used with the btrfs snapshotter: skip plugin" type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.587939794Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.587978963Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.native\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.588046552Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.overlayfs\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.588212621Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.fuse-overlayfs\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.588285135Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.stargz\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.590045553Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.zfs\"..." type=io.containerd.snapshotter.v1
time="2023-06-14T16:57:42.590247429Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.zfs\"..." error="path /var/lib/rancher/k3s/agent/containerd/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter: skip plugin" type=io.containerd.snapshotter.v1

@github-project-automation github-project-automation bot moved this from To Test to Done Issue in K3s Development Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants