Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary file_windows.go #7844

Closed
manuelbuil opened this issue Jul 3, 2023 · 1 comment
Closed

Unnecessary file_windows.go #7844

manuelbuil opened this issue Jul 3, 2023 · 1 comment
Assignees
Milestone

Comments

@manuelbuil
Copy link
Contributor

Environmental Info:
K3s Version:

Node(s) CPU architecture, OS, and Version:

Cluster Configuration:

Describe the bug:

k3s contains two files which do exactly the same but one is only included in windows builds and the other in linux builds:

  • /pkg/util/file.go (linux)
  • /pkg/util/file_windows.go (windows)

There is no need for that because all calls work for both linux and windows (e.g. os.chmod), so we can just use one file for both OS

Steps To Reproduce:

  • Installed K3s:

Expected behavior:

Actual behavior:

Additional context / logs:

@manuelbuil
Copy link
Contributor Author

Closing as there is nothing to test

@github-project-automation github-project-automation bot moved this from To Test to Done Issue in K3s Development Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant