-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-1.24] etcd snapshot cleanup fails if node name changes #8186
Comments
Validated on release-1.24 branch with commit id: b0bf7e7Environment DetailsInfrastructure
Node(s) CPU architecture, OS, and Version:
Cluster Configuration:
Config.yaml: Main ETCD SERVER (+CONTROL PLANE) CONFIG:
Sample Secondary Etcd, control plane config.yaml:
AGENT CONFIG:
Testing Steps
Note: First round node-names:
Reproduce issue Using Version:
4a. Also check the s3 bucket/folder in aws to see the snapshots listed.
7a. Also check the s3 bucket/folder in aws to see the snapshots listed.
Replication Results:
After multiple node name updates:
List of Snapshots in local directory:
As we can see above, previous snapshots with different node-names are still listed and not cleaned up. Validation Results:
Node-names used for the main etcd server in order since deployment:
The snapshots listed are:
As we can see, the previous snapshots with old node-names are no longer retained and get cleaned up. |
This is a backport issue for rancher/rke2#3714,
Node(s) CPU architecture, OS, and Version:
ubuntu 22.04
Cluster Configuration:
HA - 3 server/1agent
Describe the bug:
same as rancher/rke2#3714
since the change is getting pushed into k3s, creating this to reverify the same on k3s as well.
Steps To Reproduce:
The etcd snapshot retention, currently takes in the node-name value as well into consideration. So if node name changes, the previous snapshots for the same etcd are not cleaned up right.
Expected behavior:
Cleanup of etcd-snapshots should happen irrespective of node name changes.
Other linked code fixes:
#8124
#8191
The text was updated successfully, but these errors were encountered: