Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Remove unnecessary daemonset addition/deletion #7696

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

dereknola
Copy link
Member

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

  • Remove unnecessary daemonset IT clause
  • Remove broken/unused DeleteWorkload function.

Types of Changes

E2E testing

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner June 8, 2023 17:44
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.48 🎉

Comparison is base (00f3e24) 47.54% compared to head (9974f0c) 52.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7696      +/-   ##
==========================================
+ Coverage   47.54%   52.03%   +4.48%     
==========================================
  Files         141      141              
  Lines       14358    14358              
==========================================
+ Hits         6827     7471     +644     
+ Misses       6445     5710     -735     
- Partials     1086     1177      +91     
Flag Coverage Δ
e2etests 49.80% <ø> (?)
inttests 45.01% <ø> (+0.12%) ⬆️
unittests 19.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants