k8gb crashes on malformed spec section in gslb custom resource

[somaritane]

When gslb spec contains wrong path section for host: rule e.g:

spec:
  ingress:
    rules:
    - host: host.examle.com
       https: <==== should be http instead!
         paths:
...
  strategy:
    dnsTtlSeconds: 30
    splitBrainThresholdSeconds: 300
    type: roundRobin

this leads to panic and k8g controller crash.
Following can be seen in k8gb log

E0212 07:54:49.306061       1 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)

[somaritane]

https://gist.github.com/somaritane/2b65ada535bfcf9d4008a92c194601f0

[kuritka]

• Also nil or empty http would be handled. ( Validate spec.ingress.rules.host #299 ).

[ytsarev]

Shouldn't we actually handle https as well? Especially for annotated Ingress scenario

[somaritane]

Shouldn't we actually handle https as well? Especially for annotated Ingress scenario

@ytsarev, are we talking about TLS handling? If yes, tls section of Ingress spec handles that, there's no such thing as https path rule.

[ytsarev]

@somaritane ok, let's not complicate it until it is really required :D

[k0da]

via https://github.com/AbsaOSS/k8gb/pull/313