Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing DNSEndpoint resources are not re-labeled with dnstype after v0.7.5 upgrade #324

Closed
somaritane opened this issue Feb 26, 2021 · 0 comments · Fixed by #443
Closed

Existing DNSEndpoint resources are not re-labeled with dnstype after v0.7.5 upgrade #324

somaritane opened this issue Feb 26, 2021 · 0 comments · Fixed by #443
Assignees
@k0da
Labels
bug Something isn't working
Milestone
0.8

Comments

@somaritane
Copy link
Contributor

Existing DNSEndpoints are not being re-labeled with k8gb.absa.oss/dnstype=local, after k8gb controller is upgraded by helm to v0.7.5, which affects DNS resolution.

❯ k get dnsendpoints.externaldns.k8s.io --show-labels -A
NAMESPACE   NAME                     AGE    LABELS
test-gslb   test-gslb-failover-tls   2d1h   <none>

Only when DNSEndpoint is deleted, it gets recreated with proper label and then can be filtered by CoreDNS:

❯ k get dnsendpoints.externaldns.k8s.io --show-labels -A
NAMESPACE   NAME                     AGE     LABELS
test-gslb   test-gslb-failover-tls   2m56s   k8gb.absa.oss/dnstype=local
@somaritane somaritane added the bug Something isn't working label Feb 26, 2021
@somaritane somaritane added this to the 0.8 milestone Mar 10, 2021
@k0da k0da self-assigned this Apr 14, 2021
@k0da k0da mentioned this issue Apr 14, 2021
Merged
@k0da k0da closed this as completed in #443 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k0da k0da

Labels
bug Something isn't working
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

FIX: Annotate and Label existing DNSEndpoints k8gb-io/k8gb
2 participants
@somaritane @k0da