Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

feature request: more advanced promtail configurations #107

Open
gclawes opened this issue Nov 9, 2021 · 4 comments
Open

feature request: more advanced promtail configurations #107

gclawes opened this issue Nov 9, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gclawes
Copy link

gclawes commented Nov 9, 2021

Details

Helm chart name: common

Describe the solution you'd like:

The current promtail addon scrape configs are limited to static configs with a job and __path__ label. This makes it difficult to identify what pod a scrape job comes from, or distinguish multiple instances of a job.

Anything else you would like to add:

  • enable -config.expand-env=true to allow pod environment variables to be used in labels
  • Allow relabeling configs

Additional Information:

I'm somewhat new to using promtail. If there's a reason this doesn't make sense, or a better way to do it, I'd be glad to hear.

@gclawes gclawes added the enhancement New feature or request label Nov 9, 2021
@onedr0p onedr0p added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 9, 2021
@onedr0p
Copy link
Member

onedr0p commented Nov 10, 2021

@gclawes this would be excellent. if you want to try and get a PR together we will review. Thanks!

@onedr0p
Copy link
Member

onedr0p commented Jan 3, 2022

It might be better to deprecate the promtail addon and use vector instead, but that's because I have become more a fan of that over promtail :D

@gclawes
Copy link
Author

gclawes commented Jan 3, 2022

Hi! Sorry for the late response. If vector can support pushing to Loki and additional labeling like promtail does.

I'm still interested in contributing to this, but I have to get approval to make open-source contributions from my employer, and that may take some time.

@onedr0p
Copy link
Member

onedr0p commented Jan 4, 2022

No worries, vector can do all that and more. It's very cool, be sure to check it out: https://vector.dev

You can see my in cluster replacement for promtail here:
https://github.com/onedr0p/home-ops/blob/main/cluster/apps/monitoring/vector-agent/helm-release.yaml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants