-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Slack output #133
Comments
Hi, @AlexsJones! This sounds interesting to me. Would like to pick it up. |
Hi @rakshitgondwal, @arbreezy and I have discussed this and he will probably take on the initial implementation, but would you like to assist with that? |
Yes! I'd like to learn more about this. |
#377 is a bit wider than this discussion. This thread only takes Slack into account. I'm wondering if we can generalise this for any web hook endpoint. Further thought: Can we make this work for OAuth2 enabled endpoints (where there's a 2 step process to first retrieve a token then send the actual request). Slack (AFAIK) works on the API token (fire and forget), which IMO is simpler and nicer - but it seems that lots of people love OAuth2. |
I don't see how we can generalise the endpoint cause the accepted json message may be different in slack, discord, MS teams so on and so forth. We can make a generic implementation which will make it easy to construct different json payloads based on the reporting provider. |
Checklist
Is this feature request related to a problem?
No
Problem Description
No response
Solution Description
In order to provide even more value to users we should give them ability to alert slack
e.g.
The idea is that this would let the user drop in a slack webhook to a pre-configured instance/channel
The main area for refactoring code would be here
I would suggest adding an additional
sinks.Emit()
style method and a new packagepkg/sinks/slack
where thesinks
manager would have Slack as a registered sink type, we would also need aConfigure
method that is setup when the webhook is first detected on the CRBenefits
Slack messages
Potential Drawbacks
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: