Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: manual restart of k8sgpt-deployment pod needed when openai-api-key gets changed #137

Open
2 tasks done
jkleinlercher opened this issue May 31, 2023 · 1 comment

Comments

@jkleinlercher
Copy link
Contributor

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

Yes

Problem Description

I needed to change the openai-api-key but the old key was used until I restarted the k8sgpt-deployment pod. From my point of view this is suboptimal.

Solution Description

We should mount the secret as a vollume and reread it if it gets changed.

Benefits

When changing the openai-api-key in the kubernetes secret there is no other manual thing to do.

Potential Drawbacks

No response

Additional Information

No response

@arbreezy
Copy link
Member

arbreezy commented Jun 6, 2023

I think it's easier to sort out this by watching the changes in the secret and then restart the container to read the new value, otherwise we have to change the serve mode in k8sgpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants