-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor the ai spec #159
Conversation
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Nocache: config.Spec.NoCache, | ||
Backend: string(config.Spec.Backend), | ||
Backend: string(config.Spec.AI.Backend), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexsJones , not part of this PR but just spotted it, we can remove the string() now that Backend is not a different type
}, | ||
{ | ||
Name: "K8SGPT_BACKEND", | ||
Value: string(config.Spec.Backend), | ||
Value: string(config.Spec.AI.Backend), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
Closes #
π Description
β Checks
βΉ Additional Information