feat(operator): add namespace to grafanaDashboard #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateSousa
force-pushed
the
feat-enable-users-to-define-configmap-ns
branch
from
200d44f
to
946d5a0
Compare
|
hey @MateSousa thanks for the PR and the interest in the project. I believe we want something similar to what we define in prometheus stanza, whereby if |
The `namespace` field has been added to the `grafanaDashboard` section of the `values.yaml` file. This allows the Grafana dashboard to be deployed to a specific namespace, which improves organization and separation of concerns. Signed-off-by: MateSousa <matessousa@outlook.com>
The namespace field is added to the metadata section of the Grafana dashboard YAML file. This allows the dashboard to be created in the specified namespace, which improves organization and management of the dashboard. Signed-off-by: MateSousa <matessousa@outlook.com>
…t-overview dashboard The namespaceSelector is added to the k8sgpt-overview dashboard to allow it to be displayed in the namespace specified in the values.yaml file. This improves the flexibility of the dashboard as it can now be displayed in any namespace specified in the values.yaml file. Signed-off-by: MateSousa <matessousa@outlook.com>
…hboard in values.yaml The namespace field in the grafanaDashboard section of the values.yaml file is not needed as it is commented out and has no value. Removing it improves the readability of the file. Signed-off-by: MateSousa <matessousa@outlook.com>
MateSousa
force-pushed
the
feat-enable-users-to-define-configmap-ns
branch
from
58399e6
to
a30ac6c
Compare
|
@arbreezy i guess it would be like that, right? |
AlexsJones
previously approved these changes
Jun 26, 2023
arbreezy
requested changes
Jun 28, 2023
The namespace configuration for the Grafana dashboard has been simplified by removing the unnecessary namespaceSelector block. Instead, the namespace is directly set using the .Values.grafanaDashboard.namespace value, falling back to the default namespace if not provided. This change improves readability and reduces complexity in the configuration file. Signed-off-by: MateSousa <matessousa@outlook.com>
arbreezy
approved these changes
Jun 29, 2023
|
@MateSousa thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138
📑 Description
The
namespacefield has been added to thegrafanaDashboardsection of thevalues.yamlfile. This allows the Grafana dashboard to be deployed to a specific namespace, which improves organization and separation of concerns.✅ Checks