Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add azure remote cache #246

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

arbreezy
Copy link
Member

@arbreezy arbreezy commented Oct 20, 2023

Closes #

πŸ“‘ Description

PR refactors remoteCache CR spec and adds support for azure storage container

We only support Service Principal's Azure authentication mechanism, if we see that users want more flexibility we can extend the ways to authenticate to Azure in the operator..

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

new spec is

...
remoteCache:
  credentials:
      name: k8sgpt-sample-cache-secret
  s3:
    bucketName:
    region:
  azure:
    storageAccount:
    containerName:
...

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
@arbreezy arbreezy marked this pull request as ready for review October 22, 2023 14:16
@arbreezy arbreezy requested review from a team as code owners October 22, 2023 14:16
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to refactor the config API soon it's getting a bit unwieldy

@arbreezy arbreezy merged commit 610e5de into k8sgpt-ai:main Nov 6, 2023
6 checks passed
@arbreezy arbreezy deleted the feat/azure-cache branch November 6, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants