fix: operator's cluster role permissions to match k8sgpt #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com>
AlexsJones
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248 #252
📑 Description
This PR fixes the RBAC issues introduced in the 0.0.22 release.
Effectively K8s won't allow an SA to create cluster roles more permissive than its own cluster roles,
so we match the permission which will be eventually set for the K8sgpt cluster role.
✅ Checks
ℹ Additional Information
I will create a new feature request to lift and shift all the RBAC related resources to Helm chart templates which will be more clear to the user what roles will be created by K8sGPT operator whilst avoiding this matching pattern between the two cluster roles