Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: wrong indent for extraOptions in readme #276

Closed
3 of 4 tasks
jkleinlercher opened this issue Nov 30, 2023 · 0 comments · Fixed by #281
Closed
3 of 4 tasks

[Bug]: wrong indent for extraOptions in readme #276

jkleinlercher opened this issue Nov 30, 2023 · 0 comments · Fixed by #281

Comments

@jkleinlercher
Copy link
Contributor

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've included steps to reproduce the behavior

Affected Components

  • K8sGPT (CLI)
  • K8sGPT Operator

K8sGPT Version

v0.3.16

Kubernetes Version

v1.26.0

Host OS and its Version

No response

Steps to reproduce

the indent in

# extraOptions:
# backstage:
# enabled: true
is wrong in my opinion. extraOptions should be at the same level as "integration" or "filters", and is not part of integrations. right?
in my optinion all indents are a little bit broken. I try to fix it in the "expected behaviour" section. However, please have a deeper look. Could be that I misunderstood the things ..

Expected behaviour

  #integrations:
  #  trivy:
  #    enabled: true
  #    namespace: trivy-system
  #  filters:
  #    - Ingress
  #  sink:
  #    type: slack
  #    webhook: <webhook-url>
  #extraOptions:
  #  backstage:
  #    enabled: true

Actual behaviour

  #integrations:
  # trivy:
  #  enabled: true
  #  namespace: trivy-system
  # filters:
  #   - Ingress
  # sink:
  #   type: slack
  #   webhook: <webhook-url>
  # extraOptions:
  #   backstage:
  #     enabled: true

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant