Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nodeSelector to Chart and k8sgpt-operator #292

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat: add nodeSelector to Chart and k8sgpt-operator #292

merged 3 commits into from
Dec 20, 2023
+38 −8

Conversation

tozastation
Copy link
Contributor

@tozastation tozastation commented Dec 11, 2023 •
edited
Loading

Closes #286

📑 Description

  • add nodeSelector to Chart
  • add nodeSelector to k8sgpt-operator
  • generate crd bases by Makefile

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

  • tested on local kind cluster
    • with/without add nodeSelector
      • k8sgpt-operator
      • k8sgpt-deployment

@tozastation
feat: add nodeSelector to Chart and k8sgpt-operator
65a91d2 
Signed-off-by: tozastation <tozastation@gmail.com>
@tozastation tozastation requested review from a team as code owners December 11, 2023 07:46
@AlexsJones
Copy link
Member

First time contributor, you rock @tozastation

@tozastation
Copy link
Contributor Author

@AlexsJones
thank you !
2 pending reviews, I know you're busy, but maybe I should remind you of the review?

thschue
thschue approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit c008d22 into k8sgpt-ai:main Dec 20, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

@thschue thschue thschue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: add nodeSelector to operator
3 participants
@tozastation @AlexsJones @thschue