Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bedrock support #389

Merged
merged 4 commits into from
Mar 28, 2024
Merged

feat: bedrock support #389

merged 4 commits into from
Mar 28, 2024

Conversation

AlexsJones
Copy link
Member

Closes #

📑 Description

✅ Checks

  • [x ] My pull request adheres to the code style of this project
  • [ x] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [ x] All the tests have passed

ℹ Additional Information

@AlexsJones
feat: updated the bedrock secret setting
bf5681d 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
chore: updated CONTRIBUTING.md
7b5ab6a 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners March 27, 2024 09:04
@AlexsJones AlexsJones changed the title fix: bedrock feat: bedrock support Mar 27, 2024
arbreezy
arbreezy previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can't test it against bedrock though

I am a broken record but we also have to update the chart's crd templates (it's still manual)

JuHyung-Son
JuHyung-Son previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

i left a question in kustomization image

config/manager/kustomization.yaml Show resolved Hide resolved
@AlexsJones
chore: updated chart
460fbdc 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones dismissed stale reviews from JuHyung-Son and arbreezy via 460fbdc March 28, 2024 07:36
@AlexsJones
Copy link
Member Author

lgtm, can't test it against bedrock though

I am a broken record but we also have to update the chart's crd templates (it's still manual)

Thanks updated the chart 👍🏽

@AlexsJones AlexsJones merged commit 796f212 into main Mar 28, 2024
6 of 7 checks passed
@AlexsJones AlexsJones deleted the feat/bedrock branch March 28, 2024 07:37
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbreezy arbreezy arbreezy left review comments

@JuHyung-Son JuHyung-Son JuHyung-Son left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexsJones @arbreezy @JuHyung-Son