Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: add interval on ai backend request #419

Open
2 tasks done
JuHyung-Son opened this issue Apr 10, 2024 · 7 comments · May be fixed by #426
Open
2 tasks done

[Feature]: add interval on ai backend request #419

JuHyung-Son opened this issue Apr 10, 2024 · 7 comments · May be fixed by #426
Assignees
@VaibhavMalik4187

Comments

@JuHyung-Son
Copy link
Contributor

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

No response

Solution Description

add ai backend request interval.
if set, Sends requests to the AI backend server at set intervals, independent of the reconciler loop.
this interval should be equal or higher than reconciliation's requeue interval.

Benefits

More control over ai backend requests.

Potential Drawbacks

No response

Additional Information

No response
@arbreezy
Copy link
Member

@JuHyung-Son I think we should move this to the operator's repo, right ?

@JuHyung-Son
Copy link
Contributor Author

oh right i will move this

@JuHyung-Son JuHyung-Son transferred this issue from k8sgpt-ai/k8sgpt Apr 20, 2024
@arbreezy
Copy link
Member

@VaibhavMalik4187 would you like to assign it to you ?

@VaibhavMalik4187
Copy link
Contributor

@VaibhavMalik4187 would you like to assign it to you ?

Yes please

@VaibhavMalik4187
Copy link
Contributor

@arbreezy, @JuHyung-Son, I've been working on this issue but I have a few questions.

  1. Why not just adjust the existing reconcile interval based on the interval value received from the user?
  2. Is there any specific reason behind keeping the interval equal to or longer than the existing reconcile interval?

@JuHyung-Son
Copy link
Contributor Author

JuHyung-Son commented Apr 24, 2024 •
edited
Loading

good questions!

  1. Because reconcile does lots of things. like create new deployments, read k8sgpt crd, k8sgpt analyze ... and we want to add llm backend request interval. so it should be seperated. it will make problem if reconcile interval is 1 hour.
  2. llm request should be called after reconciler execute k8sgpt analyze.

@VaibhavMalik4187
Copy link
Contributor

good questions!

1. Because reconcile does lots of things. like create new deployments, read k8sgpt crd, k8sgpt analyze ... and we want to add llm backend request interval. so it should be seperated. it will make problem if reconcile interval is 1 hour.

2. llm request should be called after reconciler execute k8sgpt analyze.

Understood, thanks for the detailed answers.

@VaibhavMalik4187 VaibhavMalik4187 linked a pull request Apr 25, 2024 that will close this issue
Draft
4 tasks
VaibhavMalik4187 added a commit to VaibhavMalik4187/k8sgpt-operator that referenced this issue Apr 25, 2024
@VaibhavMalik4187
feature: add interval on AI backend request
d2caa51 
This commit introduces the ability to send the requests to the backend
AI server at set intervals, independent of the reconciler's requeue
requests.

To utilize this feature, the `Interval` field in the `AI` settings must
be set in the k8sgpt configuration object. Also, the specified interval
must be greater than or equal to the reconciler's requeue interval as
the llm requests should be called after the reconciler executes k8sgpt
analyze.

Fixes: k8sgpt-ai#419

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
VaibhavMalik4187 added a commit to VaibhavMalik4187/k8sgpt-operator that referenced this issue Apr 29, 2024
@VaibhavMalik4187
feature: add interval on AI backend request
470c2dd 
This commit introduces the ability to send the requests to the backend
AI server at set intervals, independent of the reconciler's requeue
requests.

To utilize this feature, the `Interval` field in the `AI` settings must
be set in the k8sgpt configuration object. Also, the specified interval
must be greater than or equal to the reconciler's requeue interval as
the llm requests should be called after the reconciler executes k8sgpt
analyze.

Fixes: k8sgpt-ai#419

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VaibhavMalik4187 VaibhavMalik4187

Labels
None yet
Projects
Backlog
Status: Proposed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: add interval on AI backend request VaibhavMalik4187/k8sgpt-operator
3 participants
@arbreezy @JuHyung-Son @VaibhavMalik4187